Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command. - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Date
Msg-id 4DFCAA94.80409@dunslane.net
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
List pgsql-hackers

On 06/18/2011 09:19 AM, Tom Lane wrote:
> Thom Brown<thom@linux.com>  writes:
>> On 18 June 2011 04:13, Bruce Momjian<bruce@momjian.us>  wrote:
>>> I tested on FreeBSD 7.4 and saw a 1 error return:
>> And on a Mac (so through Darwin 10.7.0 a BSD version too):
> Yeah, see yesterday's discussion on pgsql-admin.  I think the behavior
> with the error return may be a BSD-ism.  In any case, GNU cp does *not*
> do what we want, and that accounts for a sufficiently large fraction of
> machines in the field that I think it's just unsafe to suggest using
> "cp -i" so prominently.  There are too many people who'll just copy and
> paste the first example provided, especially if the warning to test it
> is buried several paragraphs later.
>
>             

Yeah, I'm glad to see this go anyway. I always thought the example was 
too cute by half. Using an explicit test is much nicer and more obvious.

cheers

andrew


pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: crash-safe visibility map, take five
Next
From: Bruce Momjian
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.