On 10.06.2011 19:05, Kevin Grittner wrote:
> I found that pgindent would like to tweak whitespace in three places
> in that patch, and I found an unnecessary include that I would like
> to remove. Normally, I would post a new version of the patch with
> those adjustments, but there's been a disquieting tendency for
> people to not look at what's actually happening with revisions of
> this patch and act like the sky is falling with each refinement.
>
> Let me be clear: each posted version of this patch has been safe and
> has been an improvement on what came before. Dan and I didn't
> disagree about what to do at any point; Dan figured out what to do
> with two calls I left alone because I faded before I could work out
> how to deal with them. Essentially we collaborated on-list rather
> than discussing things off-list and posting the end result. Perhaps
> that was a bad choice, but time was short and I had hopes that a
> change people had requested could be included in beta2.
I did some further changes, refactoring SkipSerialization so that it's
hopefully more readable, and added a comment about the side-effects. See
attached. Let me know if I'm missing something.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
