Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc
Date
Msg-id 4DDC91FB.7040008@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 25.05.2011 00:58, Tom Lane wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com>  writes:
>> On 22.05.2011 21:18, Tom Lane wrote:
>>> I'm also concerned that you've probably
>>> added cycles on net to MemoryContextAlloc (where it's no longer possible
>>> to tail-call AllocSetAlloc), which could very easily cost more cycles on
>>> most workloads than could ever be saved by making MemoryContextReset a
>>> shade faster.
>
>> Good point. That would be solved by clearing the flag before the
>> AllocSetAlloc() call. I don't see any harm in clearing the flag before
>> actually doing the allocation.
>
> Done that way.

Ok, thanks.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Convert builddoc.bat into a perl script that actually works.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Put options in some sensible order