Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc
Date
Msg-id 18842.1306274310@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: pgsql: Pull up isReset flag from AllocSetContext to MemoryContext struc
List pgsql-committers
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> On 22.05.2011 21:18, Tom Lane wrote:
>> I'm also concerned that you've probably
>> added cycles on net to MemoryContextAlloc (where it's no longer possible
>> to tail-call AllocSetAlloc), which could very easily cost more cycles on
>> most workloads than could ever be saved by making MemoryContextReset a
>> shade faster.

> Good point. That would be solved by clearing the flag before the
> AllocSetAlloc() call. I don't see any harm in clearing the flag before
> actually doing the allocation.

Done that way.

            regards, tom lane

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Cleanup for pull-up-isReset patch.
Next
From: Tom Lane
Date:
Subject: pgsql: Grammar cleanup for src/test/isolation/README