Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding - Mailing list pgsql-hackers

On 04/15/2011 04:36 PM, Peter Eisentraut wrote:
> On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote:
>> Yeah, what is the point of this?:
>>
>>      -# Adjust REGRESS_OPTS because we need a UTF8 database
>>      -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale
>>      +# We need a UTF8 database +ENCODING = UTF8 +NO_LOCALE = 1
>>
>>
>> Wouldn't it have worked just to change the way we spelled the option
>> name in the REGRESS_OPTS line?
> It would have, but this way you have the same uniform interface
> everywhere.  For example, you can easily override the encoding that that
> test prescribes.
>


Well whatever we do, the buildfarm is currently broken for all MSVC 
builds because of this change, so I hope you're intending to fix this.

cheers

andrew