Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding
Date
Msg-id 1302899760.3774.22.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote:
> Yeah, what is the point of this?:
> 
>     -# Adjust REGRESS_OPTS because we need a UTF8 database
>     -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale
>     +# We need a UTF8 database +ENCODING = UTF8 +NO_LOCALE = 1
> 
> 
> Wouldn't it have worked just to change the way we spelled the option 
> name in the REGRESS_OPTS line?

It would have, but this way you have the same uniform interface
everywhere.  For example, you can easily override the encoding that that
test prescribes.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: regression test client encoding
Next
From: Peter Eisentraut
Date:
Subject: Re: regression test client encoding