Re: pl/python explicit subtransactions - Mailing list pgsql-hackers

From Jan Urbański
Subject Re: pl/python explicit subtransactions
Date
Msg-id 4D5667DF.2060705@wulczer.org
Whole thread Raw
In response to Re: pl/python explicit subtransactions  (Steve Singer <ssinger_pg@sympatico.ca>)
Responses Re: pl/python explicit subtransactions  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On 11/02/11 17:22, Steve Singer wrote:
> On 11-02-10 05:20 AM, Jan Urbański wrote:
>>
>> D'oh, I was thinking about whether it's safe to skip the internal
>> subxact if you're in an implicit one and somehow I always convinced
>> myself that since you eventually close the explicit one, it is.
>>
>> Obviously my testing wasn't enough :( Attaching an updated patch with
>> improved docs incorporating Steve's fixes, and fixes & tests for not
>> statring the implicit subxact. That actually makes the patch a bit
>> smaller ;) OTOH I had to remove the section from the docs that claimed
>> performance improvement due to only starting the explicit subxact...
>>
>
> This version of the patch looks fine to me and seems to work as expected.

Thanks,

attached is a version merged with master.

Jan

Attachment

pgsql-hackers by date:

Previous
From: Alex Hunsaker
Date:
Subject: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.
Next
From: Jan Urbański
Date:
Subject: Re: pl/python custom exceptions for SPI