Re: Named restore points - Mailing list pgsql-hackers

From Euler Taveira de Oliveira
Subject Re: Named restore points
Date
Msg-id 4D517851.2050608@timbira.com
Whole thread Raw
In response to Re: Named restore points  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Named restore points  (Simon Riggs <simon@2ndQuadrant.com>)
Re: Named restore points  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Em 08-02-2011 11:05, Simon Riggs escreveu:
> On Fri, 2011-02-04 at 21:15 -0500, Jaime Casanova wrote:
>>>
>>> +       else if (recoveryTarget == RECOVERY_TARGET_NAME)
>>> +               snprintf(buffer, sizeof(buffer),
>>> +                                "%s%u\t%s\t%s named restore point %
>> s\n",
>>> +                                (srcfd<  0) ? "" : "\n",
>>> +                                parentTLI,
>>> +                                xlogfname,
>>> +                                recoveryStopAfter ? "after" :
>> "before",
>>> +                                recoveryStopNamedRestorePoint);
>>>
>>> It doesn't matter if it is after or before the restore point.
>> After/Before
>>> only make sense when we're dealing with transaction or time.
>> Removed.
>>>
>>
>> you're right
>
> Not sure I understand the comment "only make sense when we're dealing
> with transaction or time."  Why?
>
Because named restore point is a noop xlog record; besides, transaction and 
time involves xlog records that contain data.


--   Euler Taveira de Oliveira  http://www.timbira.com/


pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Range Types
Next
From: Simon Riggs
Date:
Subject: Re: Named restore points