Re: Named restore points - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Named restore points
Date
Msg-id 1297173915.1770.7791.camel@ebony
Whole thread Raw
In response to Re: Named restore points  (Jaime Casanova <jaime@2ndquadrant.com>)
Responses Re: Named restore points  (Euler Taveira de Oliveira <euler@timbira.com>)
List pgsql-hackers
On Fri, 2011-02-04 at 21:15 -0500, Jaime Casanova wrote:
> >
> > +       else if (recoveryTarget == RECOVERY_TARGET_NAME)
> > +               snprintf(buffer, sizeof(buffer),
> > +                                "%s%u\t%s\t%s named restore point %
> s\n",
> > +                                (srcfd < 0) ? "" : "\n",
> > +                                parentTLI,
> > +                                xlogfname,
> > +                                recoveryStopAfter ? "after" :
> "before",
> > +                                recoveryStopNamedRestorePoint);
> >
> > It doesn't matter if it is after or before the restore point.
> After/Before
> > only make sense when we're dealing with transaction or time.
> Removed.
> >
> 
> you're right

Not sure I understand the comment "only make sense when we're dealing
with transaction or time."  Why?

At present, I think the ability to stop before/after a named restore
point should be put back.
-- Simon Riggs           http://www.2ndQuadrant.com/books/PostgreSQL Development, 24x7 Support, Training and Services



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Named restore points
Next
From: Andrew Dunstan
Date:
Subject: Re: arrays as pl/perl input arguments [PATCH]