Re: SSI patch version 14 - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: SSI patch version 14
Date
Msg-id 4D49974F.4070403@enterprisedb.com
Whole thread Raw
In response to Re: SSI patch version 14  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-hackers
On 02.02.2011 19:36, Kevin Grittner wrote:
> Heikki Linnakangas  wrote:
>
>> Suppressing detail seems easiest. AFAICS all the variable parts are
>> in errdetail.
>
> I pushed that with some work on the tests.  If you could review the
> changes to isolationtester.c to confirm that they look sane, I'd
> appreciate it.
>
>
http://git.postgresql.org/gitweb?p=users/kgrittn/postgres.git;a=commitdiff;h=2e0254b82a62ead25311f545b0626c97f9ac35b4#patch6
>
> If that part is right, it shouldn't take me very long to finish the
> specs and capture the expected results.

Looks good. A comment would be in order to explain why we only print the 
primary message. (yeah, I know I didn't comment the tester code very 
well myself)

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: SSI patch version 14
Next
From: "Kevin Grittner"
Date:
Subject: Re: SSI patch version 14