Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Date
Msg-id 4CC1B0DA.3070907@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 22.10.2010 18:10, Tom Lane wrote:
> * You forgot a semicolon here:
>
> +           | ColId_or_Sconst                       { $$ = $1 }
> should be
> +           | ColId_or_Sconst                       { $$ = $1; }
>
> I think this will work as-is in some versions of bison, but not all.

Ah yes, it worked for me.

> * The SGML documentation keyword appendix needs an update too, no?

Hmm, I thought the list is automatically updated, but apparently not.

Thanks, fixed.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Add semicolon, missed in previous patch. And update the keyword