Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Date
Msg-id 23250.1287760228@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-committers
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> Make OFF keyword unreserved.

Two comments:

* You forgot a semicolon here:

+           | ColId_or_Sconst                       { $$ = $1 }
should be
+           | ColId_or_Sconst                       { $$ = $1; }

I think this will work as-is in some versions of bison, but not all.

* The SGML documentation keyword appendix needs an update too, no?

            regards, tom lane

pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to