Re: [PATCH] backend: compare word-at-a-time in bcTruelen - Mailing list pgsql-hackers

From Stefan Kaltenbrunner
Subject Re: [PATCH] backend: compare word-at-a-time in bcTruelen
Date
Msg-id 4B84219A.9000602@kaltenbrunner.cc
Whole thread Raw
In response to Re: [PATCH] backend: compare word-at-a-time in bcTruelen  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] backend: compare word-at-a-time in bcTruelen
List pgsql-hackers
Tom Lane wrote:
> Stefan Kaltenbrunner <stefan@kaltenbrunner.cc> writes:
>> hmm I tend to disagree, this patch was specifically done to address a 
>> hotspot I noticed under a given workload and it helped a lot for that 
>> workload(like getting 6000qps more is pretty neat imho).
>> While people might not use fixed width chars that often(which especially 
>> for migrated database is imho not true) it is an issue that can be seen 
>> with a rather popular database related benchmarking tool so we should 
>> not really dismiss it easily.
> 
> Nobody suggested dismissing it.  The point was that it hasn't been
> tested adequately to justify applying it now.

not sure what testing people want to get done though (there are a fair 
amount of results and profiles in the thread)?


Stefan


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] backend: compare word-at-a-time in bcTruelen
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server