Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server
Date
Msg-id 125.1266950877@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane escribi�:
>> That would be an argument for sticking this in the next CF, not for
>> applying it now --- it was submitted after the close of the last CF no?

> Sep. 29 2009?

Oh, I was thinking it had just come in recently, but looking back you're
right.  It did slip through the cracks.

However, has the patch actually been reviewed?  pg_dump is a piece of
code where it is notoriously easy for novices to do things wrong,
and this is especially true for adding output that should only come out
in particular cases.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: Re: [PATCH] backend: compare word-at-a-time in bcTruelen
Next
From: Greg Stark
Date:
Subject: Re: function side effects