Re: Tuplestore should remember the memory context it's created in - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Tuplestore should remember the memory context it's created in
Date
Msg-id 4B312E03.6060203@enterprisedb.com
Whole thread Raw
In response to Re: Tuplestore should remember the memory context it's created in  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Tuplestore should remember the memory context it's created in  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Got it.  So doesn't tuplesort have the same issue?

Tuplesort has the same general problem that the caller of puttuple needs
to be in the right resource owner. Which ought to be fixed, especially
since tuplesort doesn't require that for the memory context anymore.

But we don't use tuplesort to return tuples from functions, so it's not
broken in a user-visible way. Unless you can think of another scenario
like that.

> The patch definitely requires more than zero comments.

Sure.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: LIKE INCLUDING COMMENTS code is a flight of fancy
Next
From: Heikki Linnakangas
Date:
Subject: Re: Backup history file should be replicated in Streaming Replication?