Re: UTF8 with BOM support in psql - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: UTF8 with BOM support in psql
Date
Msg-id 4ADDD38F.50804@dunslane.net
Whole thread Raw
In response to Re: UTF8 with BOM support in psql  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: UTF8 with BOM support in psql
Re: UTF8 with BOM support in psql
List pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>   
>> Seems there is community support for accepting BOM:
>>     http://archives.postgresql.org/pgsql-hackers/2009-09/msg01625.php
>>     
>
> That discussion has approximately nothing to do with the
> much-more-invasive change that Itagaki-san is suggesting.
>
> In particular I think an automatic change of client_encoding isn't
> particularly a good idea --- wouldn't you have to change it back later,
> and is there any possibility of creating a security issue from such
> behavior?  Remember that client_encoding *IS* tied to security issues
> such as backslash escape handling.
>
>     
>   

Yeah, I don't think we should be second-guessing the user on the encoding.

What I think we might sensibly do is to eat the leading BOM of an SQL 
file iff the client encoding is UTF8, and otherwise treat it as just 
bytes in whatever the encoding is.

Should we also do the same for files passed via \copy? What about 
streams on stdin? What about files read from the backend via COPY?

cheers

andrew




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Could postgres be much cleaner if a future release skipped backward compatibility?
Next
From: Tom Lane
Date:
Subject: Re: Application name patch - v2