Re: COPY WITH CSV FORCE QUOTE * -- REVIEW - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: COPY WITH CSV FORCE QUOTE * -- REVIEW
Date
Msg-id 4A6A4CED.3010803@dunslane.net
Whole thread Raw
In response to Re: COPY WITH CSV FORCE QUOTE * -- REVIEW  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> I have reviewed this and made a small tweak in the docco. I'm just about 
>> ready to commit this, but I'm still slightly worried that passing NULL 
>> to denote all columns in this piece of grammar:
>>     
>
>   
>>             | FORCE QUOTE '*'
>>                 {
>>                     $$ = makeDefElem("force_quote", NULL);
>>                 }
>>     
>
>   
>> might be less than robust - it just feels slightly hacky, so I'd 
>> appreciate others' thoughts.
>>     
>
> I agree, that's ugly.  Why don't you use an A_Star node?
>
>             
>   

OK, Done and committed. Nice little addition.

cheers

andrew


pgsql-hackers by date:

Previous
From: Sam Mason
Date:
Subject: Re: SE-PostgreSQL Specifications
Next
From: KaiGai Kohei
Date:
Subject: Re: SE-PostgreSQL Specifications