Re: COPY WITH CSV FORCE QUOTE * -- REVIEW - Mailing list pgsql-hackers

From Tom Lane
Subject Re: COPY WITH CSV FORCE QUOTE * -- REVIEW
Date
Msg-id 14965.1248478273@sss.pgh.pa.us
Whole thread Raw
In response to Re: COPY WITH CSV FORCE QUOTE * -- REVIEW  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: COPY WITH CSV FORCE QUOTE * -- REVIEW  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> I have reviewed this and made a small tweak in the docco. I'm just about 
> ready to commit this, but I'm still slightly worried that passing NULL 
> to denote all columns in this piece of grammar:

>             | FORCE QUOTE '*'
>                 {
>                     $$ = makeDefElem("force_quote", NULL);
>                 }

> might be less than robust - it just feels slightly hacky, so I'd 
> appreciate others' thoughts.

I agree, that's ugly.  Why don't you use an A_Star node?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: COPY WITH CSV FORCE QUOTE * -- REVIEW
Next
From: Tom Lane
Date:
Subject: Re: Non-blocking communication between a frontend and a backend (pqcomm)