Re: conditional dropping of columns/constraints - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: conditional dropping of columns/constraints
Date
Msg-id 4A63DA93.9080201@dunslane.net
Whole thread Raw
In response to Re: conditional dropping of columns/constraints  (Bernd Helmle <mailings@oopsware.de>)
List pgsql-hackers

Bernd Helmle wrote:
>
> Here is a slightly updated version of the patch. I did some (very 
> minor) editing on the wording in the docs and cleaned a merge conflict 
> in tablecmds.c. I saw no code issues so far, make check passes without 
> errors. Maybe someone with more bison skills can comment on the 
> duplicated parser stuff, but it seems consistent with the rest of the 
> code.

The duplicated stuff in the grammar is pretty much what had to be done 
for other DROP IF EXISTS items to avoid shift/reduce conflicts, so it's 
quite kosher.

patch committed.

Thanks.

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros
Next
From: Tom Lane
Date:
Subject: Re: join removal