Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line
Date
Msg-id 49826b8a-e3ce-762e-95d2-8119ff872b00@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be perDATA() line  (David Christensen <david@endpoint.com>)
List pgsql-hackers
On 2/15/17 10:40, David Christensen wrote:
> Throws a build error if we encounter a different number of fields in a
> DATA() line than we expect for the catalog in question.
> 
> Previously, it was possible to silently ignore any mismatches at build
> time which could result in symbol undefined errors at link time.  Now
> we stop and identify the infringing line as soon as we encounter it,
> which greatly speeds up the debugging process.

I think this would be useful.  I haven't reviewed the code, but the
general idea looks reasonable.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] pg_basebackup -R
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes