Re: Text search segmentation fault - Mailing list pgsql-general

From Teodor Sigaev
Subject Re: Text search segmentation fault
Date
Msg-id 4981CBF2.6030008@sigaev.ru
Whole thread Raw
In response to Re: Text search segmentation fault  (Grzegorz Jaśkiewicz <gryzman@gmail.com>)
Responses Re: Text search segmentation fault  (Grzegorz Jaśkiewicz <gryzman@gmail.com>)
List pgsql-general

> Than I have quite few notes about that function:
> - affix is not checked on entry, and should be unsigned,

Could be Assert( affix>=0 && affix < Conf->nAffixData )

> - for sake of safety uint32_t should be used instead of unsigned int,
> in the cast
see patch
> - there should be some safety limit for lenght of str,
It's a C-string

--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

pgsql-general by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: Text search segmentation fault
Next
From: Grzegorz Jaśkiewicz
Date:
Subject: Re: Text search segmentation fault