Re: Text search segmentation fault - Mailing list pgsql-general

From Grzegorz Jaśkiewicz
Subject Re: Text search segmentation fault
Date
Msg-id 2f4958ff0901290734r1deebb0frc13ca35b4f771a95@mail.gmail.com
Whole thread Raw
In response to Re: Text search segmentation fault  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Text search segmentation fault  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-general
On Thu, Jan 29, 2009 at 3:26 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
> I reproduced the bug with a help of Grzegorz's point for 64-bit box. So,
> patch is attached and I'm going to commit it

:)

To be honest, looking through that file, I am quite worried about few
points. I don't know too much about insights of ispell, but I see few
suspicious things in mkSPNode too.
I generally don't want to get involve in reviewing code for stuff I
don't know, But if Teodor (and Oleg) don't mind, I can raise my
points, and see if anything useful comes out of it.

Also, about that patch - it doesn't seem to apply cleanly to 8.4,
perhaps that file has changed too much (I based my 'review' above on
8.4's code)


--
GJ

pgsql-general by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: Text search segmentation fault
Next
From: Grzegorz Jaśkiewicz
Date:
Subject: Re: Text search segmentation fault