Re: Enabling SQL text field in the SQL tab of object dialog - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Enabling SQL text field in the SQL tab of object dialog
Date
Msg-id 48B44115.3070609@lelarge.info
Whole thread Raw
In response to Re: Enabling SQL text field in the SQL tab of object dialog  ("Dave Page" <dpage@postgresql.org>)
Responses Re: Enabling SQL text field in the SQL tab of object dialog  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Dave Page a écrit :
> On Wed, Jul 9, 2008 at 12:31 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> [...]
>> I prefer to add sizing to all (properties') dialogs. This is a work I can
>> do, step by step. I think I should follow these steps in this order:
>>
>>  * one patch for each dialog to add the sizing.
>>  * one patch to add sizing on common tabs (ie "Variables", "Privileges",
>>   and "SQL").
>>  * v5 patch for the read-write/read-only mode on sql textfields.
>>
>> OK for these steps?
>
> Yup, sounds like a good plan to me.
>

Back on this. The plan took a lot more time than I initially thought.
Anyways, here is the v5 patch updated.

This patch aims to allow changes on sql text fields. The checkbox need
to be checked to allow typing in the text fields. When checked, other
tabs are unavailable. When un-checked, a confirmation dialog aks the
user if he wants to loose his changes. If yes, it replaces changes with
the previous queries. If no, it keeps the checkbox checked.

It seems to me it's ready for commit.

Comments?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

pgadmin-hackers by date:

Previous
From: "Dave Page"
Date:
Subject: Re: Dialogs Review new patch
Next
From: Guillaume Lelarge
Date:
Subject: Re: Enabling SQL text field in the SQL tab of object dialog