pg_regress: dbname in PostgreSQL test suite - Mailing list pgsql-hackers

From Jorgen Austvik - Sun Norway
Subject pg_regress: dbname in PostgreSQL test suite
Date
Msg-id 483D6868.3080806@sun.com
Whole thread Raw
Responses Re: pg_regress: dbname in PostgreSQL test suite  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pg_regress: dbname in PostgreSQL test suite  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Hi.

pg_regress has a --dbname option (which actually take a list of database
names):

   --dbname=DB               use database DB (default \"regression\")

... but the PostgreSQL regression test suite does not really support this:

[jaustvik@host:regress] ggrep -R "regression" sql/* | grep -v
regression_ | grep -v :--
sql/prepare.sql:EXECUTE q2('regression');
sql/privileges.sql:\c regression
sql/temp.sql:\c regression

I suggest we replace @dbname@ with the first element in the dblist
linked list in convert_sourcefiles_in(). What do you think?

(I can provide a patch if you think it is an acceptable solution.)

-J
--

Jørgen Austvik, Software Engineering - QA
Sun Microsystems Database Group

http://blogs.sun.com/austvik/
http://www.austvik.net/

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Upcoming back-branch update releases
Next
From: Tom Lane
Date:
Subject: Re: [JDBC] How embarrassing: optimization of a one-shot query doesn't work