Re: Proposed patch - psql wraps at window width - Mailing list pgsql-patches

From Bryce Nesbitt
Subject Re: Proposed patch - psql wraps at window width
Date
Msg-id 4808415E.5080905@obviously.com
Whole thread Raw
In response to Re: Proposed patch - psql wraps at window width  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches

Alvaro Herrera wrote:
> * Don't lose warning comments like this one (unless you've removed the
> assumption of course)
>
> /*
>  * Assumption: This code used only on strings
>  * without multibyte characters, otherwise
>  * this_line->width < strlen(this_ptr) and we get
>  * an overflow
>  */
In fact, that particular assumption was causing a problem, causing a
segfault.  I can't be certain, because the multibyte stuff is pretty
intense, but I think I nailed it.  Thanks for all your comments!


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposed patch - psql wraps at window width
Next
From: Bryce Nesbitt
Date:
Subject: Coding standards