Re: Lessons from commit fest - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Lessons from commit fest
Date
Msg-id 4806EA00.9020701@enterprisedb.com
Whole thread Raw
In response to Re: Lessons from commit fest  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Lessons from commit fest  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Alvaro Herrera wrote:
> Bruce Momjian wrote:
>> Alvaro Herrera wrote:
> 
>>> Maybe this means that we should give pgindent a run over the back
>>> branches.
>> Yea, that thought has crossed our minds, but the problem is that there
>> is little testing of back branches so it would be risky.
> 
> That's a fair point, though I wonder how can a code indenter be so
> broken that it broke code in ways not detected by our buildfarm.

Something like this:

if (foo)
{do something;do something else;
}
...

->

if (foo)do something;
do something else;
...

I wouldn't be too surprised if something like that happened with one of 
the complex macros, like PG_TRY/CATCH.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Robert Treat
Date:
Subject: Re: MERGE SQL Statement
Next
From: Heikki Linnakangas
Date:
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout