Tom Lane wrote:
> Zoltan Boszormenyi <zb@cybertec.at> writes:
>
>> Gregory Stark írta:
>>
>>> 1) Please don't include configure in your patch. I don't know why it's checked
>>> into CVS but it is so that means manually removing it from any patch. It's
>>> usually a huge portion of the diff so it's worth removing.
>>>
>
>
>> Noted.
>>
>
> Just for the record: the reason configure is in CVS is to avoid
> requiring users of CVS checkouts to have autoconf installed.
>
> Perhaps we should rethink that, but in any case there's no point
> in submitting manual diffs to configure (or any other generated
> file). Best practice is to just remind the committer that the
> generated file needs to be regenerated.
>
>
>>> 3) You could get rid of a bunch of #ifndef HAVE_LONG_INT_64 snippets by having
>>> a #define like INT64PASSBYVALUE which is defined to be either "true" or
>>> "false".
>>>
>
>
>> OK, this would also make the patch smaller.
>> Is pg_config_manual.h good for this setting?
>>
>
> I'd go for having a #define like that, but what is the reason to set it
> in pg_config_manual.h? Seems like the configure script should set it.
>
Obviously. :-) Thanks.
And:
Magnus Hagander wrote:
>
> Changes to genbki.sh also have to be "mirrored" in the msvc build
> scripts (Genbki.pm) in most cases...
>
>
> //Magnus
Thanks for the info, I modified this file as well.
Please review the change, I am not a Perl expert and
I don't have a Windows build environment.
New patch is attached.
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/
