Re: CopyReadLineText optimization - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: CopyReadLineText optimization
Date
Msg-id 47D1ACA5.80308@dunslane.net
Whole thread Raw
In response to Re: CopyReadLineText optimization  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
Responses Re: CopyReadLineText optimization  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
Re: CopyReadLineText optimization  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-patches

Heikki Linnakangas wrote:
> Andrew Dunstan wrote:
>> I'm still a bit worried about applying it unless it gets some
>> adaptive behaviour or something so that we don't cause any serious
>> performance regressions in some cases.
>
> I'll try to come up with something. At the most conservative end, we
> could fall back to the current method on the first escape, quote or
> backslash character.
>
>> Also, could we perhaps benefit from inlining some calls, or is your
>> compiler doing that anyway?
>
> gcc does inline all static functions that are only called from one
> site,  and small functions, using some heuristic. I don't think more
> aggressive inlining would help.
>

Another question that occurred to me - did you try using strpbrk() to
look for the next interesting character rather than your homegrown
searcher gadget? If so, how did that perform?

cheers

andrew

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Cleaner API for appendStringInfoVA
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords