Re: CopyReadLineText optimization - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: CopyReadLineText optimization
Date
Msg-id 47D0499F.301@enterprisedb.com
Whole thread Raw
In response to Re: CopyReadLineText optimization  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: CopyReadLineText optimization
Re: CopyReadLineText optimization
Re: CopyReadLineText optimization
List pgsql-patches
Andrew Dunstan wrote:
> I'm still a bit worried about applying it unless it gets some adaptive
> behaviour or something so that we don't cause any serious performance
> regressions in some cases.

I'll try to come up with something. At the most conservative end, we
could fall back to the current method on the first escape, quote or
backslash character.

> Also, could we perhaps benefit from inlining
> some calls, or is your compiler doing that anyway?

gcc does inline all static functions that are only called from one site,
  and small functions, using some heuristic. I don't think more
aggressive inlining would help.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: "Heikki Linnakangas"
Date:
Subject: Re: CopyReadLineText optimization
Next
From: Andrew Dunstan
Date:
Subject: Re: CopyReadLineText optimization