Re: ORDER BY pushdowns seem broken in postgres_fdw - Mailing list pgsql-hackers

From Ronan Dunklau
Subject Re: ORDER BY pushdowns seem broken in postgres_fdw
Date
Msg-id 4795577.0VBMTVartN@aivenronan
Whole thread Raw
In response to Re: ORDER BY pushdowns seem broken in postgres_fdw  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ORDER BY pushdowns seem broken in postgres_fdw
List pgsql-hackers
Le jeudi 31 mars 2022, 01:41:37 CEST Tom Lane a écrit :
> I looked through this patch.  It's going in the right direction,
> but I have a couple of nitpicks:

Thank you Tom for taking a look at this.

> I think that instead of doubling down on a wrong API, we should just
> take that out and move the logic into postgres_fdw.c.  This also has
> the advantage of producing a patch that's much safer to backpatch,
> because it doesn't rely on the core backend getting updated before
> postgres_fdw.so is.

It makes total sense.

> If no objections, I think this is committable.

No objections on my end.

--
Ronan Dunklau





pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: enhancing plpgsql debug API - returns text value of variable content
Next
From: Alvaro Herrera
Date:
Subject: Re: Database-level collation version tracking