Re: Problem with ControlFileData structure being ABI depe ndent - Mailing list pgsql-hackers

From Dave Page
Subject Re: Problem with ControlFileData structure being ABI depe ndent
Date
Msg-id 47596E31.4040005@postgresql.org
Whole thread Raw
In response to Re: Problem with ControlFileData structure being ABI depe ndent  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Problem with ControlFileData structure being ABI depe ndent  (Dave Page <dpage@postgresql.org>)
List pgsql-hackers
Tom Lane wrote:
> Dave Page <dpage@postgresql.org> writes:
>> Gregory Stark wrote:
>>> An alternative is leaving it in the project file but putting something like
>>> this in c.h:
> 
> Put it in win32.h, please.  c.h shouldn't get cluttered with
> platform-specific kluges when there's no need for it.
> 
> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?

Yeah, the fact that addons may then end up partially compiled with and 
partially without it being defined. It we just have it error as Greg 
suggested, then it will force the authors to define it themselves, and 
if they get that wrong it's their fault not ours.

/D


pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql?
Next
From: Tom Lane
Date:
Subject: Re: Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql?