Re: Fix pg_dump dependency on postgres.h - Mailing list pgsql-patches

From Zdenek Kotala
Subject Re: Fix pg_dump dependency on postgres.h
Date
Msg-id 47443512.7090308@sun.com
Whole thread Raw
In response to Re: Fix pg_dump dependency on postgres.h  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Fix pg_dump dependency on postgres.h
List pgsql-patches
Bruce Momjian wrote:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>>> Huh, I think the point is to be able to build 8.3 at all on certain
>>> Solaris releases.  I think it qualifies as a portability fix.
>> (a) it wasn't "to build at all", it was to allow "inline" to be enabled
>> on Sun Studio's compiler, which apparently is too dumb to not generate
>> copies of an unreferenced inline function.
>>
>> (b) portability fix or not, this ain't going into 8.3.  It's *far* too
>> invasive for this late stage of the cycle.
>
> Yea, that was my analysis too.
>

Yes, I agree with Bruce and Tom. It is more invasive then I expected.
And specially in context when pg_resetxlog needs to be also fixed and
this fix seems more complicated then pg_dump fix :(.

        Zdenek

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Fix pg_dump dependency on postgres.h
Next
From: Matteo Beccati
Date:
Subject: Re: Better default_statistics_target