Re: Fix pg_dump dependency on postgres.h - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Fix pg_dump dependency on postgres.h
Date
Msg-id 200711212245.lALMjuS21402@momjian.us
Whole thread Raw
In response to Re: Fix pg_dump dependency on postgres.h  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-patches
Zdenek Kotala wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> >>> Huh, I think the point is to be able to build 8.3 at all on certain
> >>> Solaris releases.  I think it qualifies as a portability fix.
> >> (a) it wasn't "to build at all", it was to allow "inline" to be enabled
> >> on Sun Studio's compiler, which apparently is too dumb to not generate
> >> copies of an unreferenced inline function.
> >>
> >> (b) portability fix or not, this ain't going into 8.3.  It's *far* too
> >> invasive for this late stage of the cycle.
> >
> > Yea, that was my analysis too.
> >
>
> Yes, I agree with Bruce and Tom. It is more invasive then I expected.
> And specially in context when pg_resetxlog needs to be also fixed and
> this fix seems more complicated then pg_dump fix :(.

The good news is that we will have it ready for 8.4.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] wrong behavior using to_char() again
Next
From: Bruce Momjian
Date:
Subject: Re: [BUGS] BUG #3770: Follow up: Fail to make bcc32.mak for libpq