Re: mingw regression test fixes - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: mingw regression test fixes
Date
Msg-id 4732.24.211.141.25.1083381772.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: mingw regression test fixes  (Claudio Natoli <claudio.natoli@memetrics.com>)
List pgsql-patches
Claudio Natoli said:
>> Strictly speaking, the pwd flags test should probably depend
>> in the test
>> platform rather than the target platform. Something like:
>>
>>  case `uname` in
>>      MINGW32*)
>>          PWDFLAGS=-W;;
>>      *)
>>          PWDFLAGS=;;
>>  esac
>
> There's three other tests that use $host_platform in pg_regress.sh in
> the exact same manner. Not sure I understand the objection.
>

if you tested a mingw build from some other platform pwd might not
understand the -W flag. It's probably a minor nit at best.

cheers

andrew



pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: FW: Timezone library
Next
From: Tom Lane
Date:
Subject: Re: width_bucket() per SQL2003 (WIP)