Re: FW: Timezone library - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: FW: Timezone library
Date
Msg-id 200405010312.i413CXO29864@candle.pha.pa.us
Whole thread Raw
In response to Re: FW: Timezone library  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > I think it would be better to put it under one of the generic
> > subdirectories, such as src/utils/timezone.  We may have to add
> > additional libraries of this kind in the future, and it would be better
> > to have them grouped somehow.
>
> The closest precedent we have at the moment is src/backend/regex, which
> is a fairly large library that we imported lock-stock-and-barrel.
> However, this precedent wouldn't hold if the code needs to be usable
> from non-backend code.  ecpg seems to want to use the tz code ...

I asked if ecpg should use the same timezone database as the server and
someone said it could just use the local one.

I was concerned ecpg would be reading structure and had to assume the
timezones split up the same way as the server.

> Right at the moment I am thinking we may end up keeping only about one
> file out of the existing src/timezone import, so maybe it doesn't need
> a whole subdirectory anyway?

Not sure, but it is easy to move.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: FW: Timezone library
Next
From: "Andrew Dunstan"
Date:
Subject: Re: mingw regression test fixes