Re: [PATCHES] snprintf() argument reordering not working - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] snprintf() argument reordering not working
Date
Msg-id 472.1133801065@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] snprintf() argument reordering not working  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCHES] snprintf() argument reordering not working  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> With 8.1_RC1 I *do* get the results Nicolai reported. With the changes I 
> made yesterday, I see the result above, i.e. what we expect from our own 
> breakage of sprintf (i haven't yet updated the snapshot I took).

Ah.  OK, that makes sense.

> But the simple fix seems to be to use our version of printf and friends. 
> The changes requires are not too invasive.

I agree with doing this even if we weren't faced with (apparently)
multiple versions of libintl that don't all work alike.  My thought is
that running our own version of snprintf on a heavily used port like
Windows is exactly what is needed to flush out any remaining bugs.
It's obviously not gotten enough field usage yet ...

Was the last patch you sent in ready for application, or are you still
fooling with it?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] snprintf() argument reordering not working
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] snprintf() argument reordering not working