Re: pgsql: Improve logging of checkpoints. - Mailing list pgsql-committers

Heikki Linnakangas wrote:
> Does this
>
>> +/* + * Log start of a checkpoint.
>> + */
>> +static void
>> +LogCheckpointStart(int flags)
>> +{
>> +    elog(LOG, "checkpoint starting:%s%s%s%s%s%s",
>> +         (flags & CHECKPOINT_IS_SHUTDOWN) ? " shutdown" : "",
>> +         (flags & CHECKPOINT_IMMEDIATE) ? " immediate" : "",
>> +         (flags & CHECKPOINT_FORCE) ? " force" : "",
>> +         (flags & CHECKPOINT_WAIT) ? " wait" : "",
>> +         (flags & CHECKPOINT_CAUSE_XLOG) ? " xlog" : "",
>> +         (flags & CHECKPOINT_CAUSE_TIME) ? " time" : "");
>> +}
>
> work with translations?

In fact, they should be ereports, not elogs. I forgot to change them
when I increased the log level from DEBUG as it was in Greg's original
patch.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com