Re: Fix for MSVC header installation - Mailing list pgsql-patches

From Dave Page
Subject Re: Fix for MSVC header installation
Date
Msg-id 462FAC84.4070607@postgresql.org
Whole thread Raw
In response to Re: Fix for MSVC header installation  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Fix for MSVC header installation  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Andrew Dunstan wrote:
> Dave Page wrote:
>> Magnus Hagander wrote:
>>> On Wed, Apr 25, 2007 at 02:57:41PM +0100, Dave Page wrote:
>>>> The MSVC installer doesn't install the headers in the same directory
>>>> structure as the Mingw build. This causes other apps (such as Slony)
>>>> to fail their configure tests.
>>>>
>>>> The attached patch fixes this.
>>>
>>> Applied, thanks.
>>>
>>> FWIW, I mimicked the install layout on my Linux box. But we should
>>> definitly be consistent with mingw instead :-)
>>
>> Hmm, wonder why they are different? Especially as 8.2.4 on
>> developer.pgadmin.org (Slackware 11) seems to have the same layout as
>> mingw!
>
>
> pg_config IYF.
>
> try:  pg_config | grep INCLUDE

Right, but some of the directories that were in the wrong place were not
  ones that could be located in the pg_config output - for example,
$INCLUDEDIR/internal was under $INCLUDEDIR/postgresql/internal.

And we really should make VC++ install in the same locations as mingw by
default anyway.

Regards, Dave.


pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Fix for MSVC header installation
Next
From: Tom Lane
Date:
Subject: Re: Fix for MSVC header installation