Re: OS timezone files support - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: OS timezone files support
Date
Msg-id 4602C553.9020603@hagander.net
Whole thread Raw
In response to Re: OS timezone files support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: OS timezone files support  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-patches
Tom Lane wrote:
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>> This patch brings possibility to switch from default build-in timezone
>> to another timezone source - typically to OS timezone location.
>
>> It was discussed few weeks ago:
>> http://archives.postgresql.org/pgsql-hackers/2007-03/msg00784.php
>
> AFAIR, the conclusion of that discussion was we didn't want it.
>
> I certainly don't see the point of the implementation as you have it
> --- it adds a great deal of unnecessary infrastructure compared to just
> installing a symlink at share/postgresql/timezone.

And if you wanted it in the backend instead of a symlink, shouldn't it
at least try to verify that the files in the timezone directory are
compatible before blindly accepting it?

//Magnus

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: contrib/spi makefile inconsistency
Next
From: Zdenek Kotala
Date:
Subject: Re: OS timezone files support