Re: Some minor changes to pgbench - Mailing list pgsql-patches

From Joshua D. Drake
Subject Re: Some minor changes to pgbench
Date
Msg-id 44ED1AA0.4020704@commandprompt.com
Whole thread Raw
In response to Re: Some minor changes to pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> "Joshua D. Drake" <jd@commandprompt.com> writes:
>> Would it be worthwhile to add a switch so that the foreign key test is
>> only used "if" they use the switch in conjunction with a -i?
>
> I wouldn't object to providing that as a (non default) option.

O.k. I will take a look at what that would take..

>
> The int8 change should be unnecessary in view of Tatsuo's recent fix
> to make the random deltas symmetrical about zero.

O.k. that may be the case, my testing was with the 8.1 version pgbench.
I will verify with -HEAD before I change the int8.

>  I would counsel
> against making the other changes either, as they seem to accomplish
> little except make the comparability of results more doubtful.

I am not interested in really changing the overall internals. I just
wanted the foreign key option.

Sincerely,

Joshua D. Drake


>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match
>


--

    === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
    Providing the most comprehensive  PostgreSQL solutions since 1997
              http://www.commandprompt.com/



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Some minor changes to pgbench
Next
From: Dhanaraj M
Date:
Subject: Re: Patch - Have psql show current values