VALUES clause memory optimization (was: Values list-of-targetlists patch...) - Mailing list pgsql-hackers

From Joe Conway
Subject VALUES clause memory optimization (was: Values list-of-targetlists patch...)
Date
Msg-id 44D140DF.5080209@joeconway.com
Whole thread Raw
In response to 8.2 features?  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: VALUES clause memory optimization (was: Values list-of-targetlists patch...)
List pgsql-hackers
Tom Lane wrote:
> I think we could safely list_free the input list in transformInsertRow
> as your patch suggests, which would buy back the 144M part.  But I don't
> believe it's safe at all to free the raw_parser output --- the grammar
> sometimes makes multiple links to the same subtree, eg in BETWEEN.

In transformExpr the comment implies that it should be safe to reapply
to an already transformed expression. What if we free the raw_parser
expression list/cells/nodes and replace it with the as-transformed one?

Joe




pgsql-hackers by date:

Previous
From: Rick Gigger
Date:
Subject: Re: 8.2 feature set
Next
From: Andreas Pflug
Date:
Subject: pg_terminate_backend