Re: Parallel safety tagging of extension functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parallel safety tagging of extension functions
Date
Msg-id 4467.1464792298@sss.pgh.pa.us
Whole thread Raw
In response to Re: Parallel safety tagging of extension functions  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Parallel safety tagging of extension functions  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
Andreas Karlsson <andreas@proxel.se> writes:
> It is the least ugly of all the ugly solutions I could think of. I have 
> attached a patch which fixes the signatures using this method. I use 
> CREATE OR REPLACE FUNCTION to update to catcache. What do you think? Is 
> it too ugly?

I don't understand why you think you need the CREATE OR REPLACE FUNCTION
commands?  We only need to change proargtypes, and the updates did that.
The catcache can take care of itself.

I think it would be good practice to be more careful about
schema-qualifying all the pg_catalog table and type names.

I also think it's a bad idea to use to_regprocedure() rather than
a cast to regprocedure.  If the name isn't found, we want an error,
not a silent NULL result leading to no update occurring.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Does people favor to have matrix data type?
Next
From: Jim Nasby
Date:
Subject: Re: Floating point comparison inconsistencies of the geometric types