Postgres Pro
Downloads
Home   >   mailing lists

Re: Generate pg_stat_get_xact*() functions with Macros - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: Generate pg_stat_get_xact*() functions with Macros
Date
Msg-id 442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com
Whole thread Raw
In response to Re: Generate pg_stat_get_xact*() functions with Macros  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Generate pg_stat_get_xact*() functions with Macros  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 3/27/23 8:40 AM, Michael Paquier wrote:
> On Mon, Mar 27, 2023 at 07:45:26AM +0200, Drouvot, Bertrand wrote:
>> Thanks! LGTM, but what about also taking care of pg_stat_get_xact_function_total_time()
>> and pg_stat_get_xact_function_self_time() while at it?
> 
> With a macro that uses INSTR_TIME_GET_MILLISEC() to cope with
> instr_time?  Why not, that's one duplication less.

Yes, something like V1 up-thread was doing. I think it can be added with your current proposal.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
Next
From: Peter Smith
Date:
Subject: Re: PGdoc: add missing ID attribute to create_subscription.sgml