Re: pgsql: Code review for spi_query/spi_fetchrow patch: - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Code review for spi_query/spi_fetchrow patch:
Date
Msg-id 43564B21.9060609@dunslane.net
Whole thread Raw
In response to Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers

Tom Lane wrote:

>David Fetter <david@fetter.org> writes:
>
>
>>On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote:
>>
>>
>>>Log Message:
>>>-----------
>>>Code review for spi_query/spi_fetchrow patch: handle errors sanely,
>>>avoid leaking memory.  I would add a regression test for error
>>>handling except it seems eval{} can't be used in unprivileged plperl
>>>:-(
>>>
>>>
>
>
>
>>What would you be using the eval{} to do?
>>
>>
>
>Catch the error inside the Perl function.
>
>
>
>

We could load plperlu in addition to plperl for the regression tests -
IIRC you made me make provision for loading multiple languages :-)

cheers

andrew

pgsql-committers by date:

Previous
From: dpage@pgfoundry.org (User Dpage)
Date:
Subject: pginstaller - pginst: Include pgAdmin3's Spanish hint files
Next
From: am@pgfoundry.org (User Am)
Date:
Subject: press - pr: Partial translation of the press release to Romanian.