Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Date
Msg-id 13698.1129668311@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors  (David Fetter <david@fetter.org>)
Responses Re: pgsql: Code review for spi_query/spi_fetchrow patch:  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
David Fetter <david@fetter.org> writes:
> On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote:
>> Log Message:
>> -----------
>> Code review for spi_query/spi_fetchrow patch: handle errors sanely,
>> avoid leaking memory.  I would add a regression test for error
>> handling except it seems eval{} can't be used in unprivileged plperl
>> :-(

> What would you be using the eval{} to do?

Catch the error inside the Perl function.

            regards, tom lane

pgsql-committers by date:

Previous
From: xzilla@pgfoundry.org (User Xzilla)
Date:
Subject: wikipedia - wikipgedia: remove obsolete files
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Code review for regexp_replace patch.