On 2023-03-27 23:28, Damir Belyalov wrote:
> Hi!
>
> I made the specified changes and my patch turned out the same as
> yours. The performance measurements were the same too.
Thanks for your review and measurements.
> The only thing left to do is how not to add IGNORE_DATATYPE_ERRORS as
> a keyword. See how this is done for parameters such as FORCE_NOT_NULL,
> FORCE_NULL, FORCE_QUOTE. They are not in kwlist.h and are not as
> keywords in gram.y.
I might misunderstand something, but I believe the v5 patch uses
copy_generic_opt_list and it does not add IGNORE_DATATYPE_ERRORS as a
keyword.
It modifies neither kwlist.h nor gram.y.
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
