Re: Naming of new tsvector functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Naming of new tsvector functions
Date
Msg-id 4328.1462370302@sss.pgh.pa.us
Whole thread Raw
In response to Re: Naming of new tsvector functions  (Stas Kelvich <s.kelvich@postgrespro.ru>)
Responses Re: Naming of new tsvector functions  (Stas Kelvich <s.kelvich@postgrespro.ru>)
List pgsql-hackers
Stas Kelvich <s.kelvich@postgrespro.ru> writes:
>> On 03 May 2016, at 00:59, David Fetter <david@fetter.org> wrote:
>> I suspect that steering that ship would be a good idea starting with
>> deprecation of the old name in 9.6, etc.  hs_filter(), perhaps?

> In 9.5 there already were tsvector functions length(), numnode(), strip()

> Recent commit added setweight(), delete(), unnest(), tsvector_to_array(), array_to_tsvector(), filter().

> Last bunch can be painlessly renamed, for example to ts_setweight, ts_delete, ts_unnest, ts_filter.

> The question is what to do with old ones? Leave them as is? Rename to ts_* and create aliases with deprecation
warning?

The other ones are not so problematic because they do not conflict with
SQL keywords.  It's only delete() and filter() that scare me.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_dump broken for non-super user
Next
From: Marc Mamin
Date:
Subject: 9.5.2: "sql" as reserved word?