Re: pg_ctl and port number detection - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_ctl and port number detection
Date
Msg-id 4326.1292713345@sss.pgh.pa.us
Whole thread Raw
In response to pg_ctl and port number detection  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_ctl and port number detection  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> pg_ctl.c::test_postmaster_connection() has some fragile code that tries
> to detect the server port number by looking in the pg_ctl -o string,

It may be fragile, but it works; or at least I've not heard complaints
about it lately.

> I think a simpler solution would be to look in postmaster.pid:
> pg_ctl already knows the data directory.  If the file is missing, the
> server is not running.  If the file exists, the first number on the last
> line, divided by 1000, is the port number.

That's somewhere between fragile and outright wrong.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Extensions, patch v20 (bitrot fixes) (was: Extensions, patch v19 (encoding brainfart fix))
Next
From: Bruce Momjian
Date:
Subject: Re: pg_ctl and port number detection