Re: pg_ctl and port number detection - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_ctl and port number detection
Date
Msg-id 201012182308.oBIN84713812@momjian.us
Whole thread Raw
In response to Re: pg_ctl and port number detection  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_ctl and port number detection  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > pg_ctl.c::test_postmaster_connection() has some fragile code that tries
> > to detect the server port number by looking in the pg_ctl -o string,
> 
> It may be fragile, but it works; or at least I've not heard complaints
> about it lately.

True.

> > I think a simpler solution would be to look in postmaster.pid:
> > pg_ctl already knows the data directory.  If the file is missing, the
> > server is not running.  If the file exists, the first number on the last
> > line, divided by 1000, is the port number.
> 
> That's somewhere between fragile and outright wrong.

Please explain why my idea is not an improvement.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_ctl and port number detection
Next
From: Tom Lane
Date:
Subject: Re: pg_ctl and port number detection