Re: compilation errors: wrong actions - Mailing list pgadmin-hackers

From Andreas Pflug
Subject Re: compilation errors: wrong actions
Date
Msg-id 430434FF.4060202@pse-consulting.de
Whole thread Raw
In response to Re: compilation errors: wrong actions  (Diego Gil <diego@adminsa.com>)
Responses Re: compilation errors: wrong actions  (Diego Gil <diego@adminsa.com>)
List pgadmin-hackers
Diego Gil wrote:
> Andreas:
>
> after a new checkout, new errors appears :
>
> .
> .
> .
> .
> ./src/include/pgUser.h:18: warning: 'class pgUserFactory' has virtual
> functions but non-virtual destructor

These are all bullsh*t. Factories are never deleted.
> ../src/agent/include/pgaJob.h:19: warning: 'class pgaJobFactory' has
> virtual functions but non-virtual destructor
> ./schema/pgServer.cpp: In member function 'virtual void
> pgServer::ShowTreeDetail(ctlTree*, frmMain*, ctlListView*, ctlSQLBox*)':
> ./schema/pgServer.cpp:738: error: 'groupRoleFactory' was not declared in
> this scope
> ./schema/pgServer.cpp:739: error: 'loginRoleFactory' was not declared in
> this scope

Yup, I broke *ix compilation because I didn't checkin the new role
files. These aren't fully tested, will take some days to do that.
To fix temporarily, simply use the previous pgServer.cpp.
This is the advantage of the new factory architecture: only pgServer
knows it might have role childs, the rest of pgAdmin is completely role
agnostic.

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: Diego Gil
Date:
Subject: Re: compilation errors: wrong actions
Next
From: Diego Gil
Date:
Subject: Re: compilation errors: wrong actions